----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2353/#review5281 -----------------------------------------------------------
Ship it! The patch seems fine. I think we should declare rngs to be thread local to begin with and have different seeds for each of these rng to avoid any correlation. - Nilay Vaish On Aug. 17, 2014, 10:51 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2353/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2014, 10:51 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10313:8f3715f67df0 > --------------------------- > base: Use STL C++11 random number generation > > This patch changes the random number generator from the in-house > Mersenne twister to an implementation relying entirely on C++11 STL. > > The format for the checkpointing of the twister is simplified. As the > functionality was never used this should not matter. Note that this > patch does not actually make use of the checkpointing > functionality. As the random number generator is not thread safe, it > may be sensible to create one generator per thread, system, or even > object. Until this is decided the status quo is maintained in that no > generator state is part of the checkpoint. > > > Diffs > ----- > > src/base/SConscript 79fde1c67ed8 > src/base/random.hh 79fde1c67ed8 > src/base/random.cc 79fde1c67ed8 > src/base/random_mt.cc 79fde1c67ed8 > > Diff: http://reviews.gem5.org/r/2353/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
