----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2330/#review5292 -----------------------------------------------------------
Ship it! - Nilay Vaish On Aug. 13, 2014, 12:51 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2330/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2014, 12:51 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10290:cb87bf7eac9b > --------------------------- > style: Fixup strange semantics in hg m5style > > The 'hg m5style' command had some rather strange semantics. When > called without arguments, it applied the style checker to all added > files and modified regions of modified files. However, when providing > a list of files, it used that list as an ignore list instead of > specifically checking those files. > > This patch makes the m5style command behave more like other Mercurial > commands where the arguments are used to specify which files to work > on instead of which files to ignore. > > > Diffs > ----- > > util/style.py 79fde1c67ed8 > > Diff: http://reviews.gem5.org/r/2330/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
