----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2331/#review5293 -----------------------------------------------------------
Ship it! Overall I am fine with the patch. Somehow I do not like the option name 'no-ignore'. How about 'ignore-ignore-list' or 'no-ignore-list' or 'avoid-ignore-list'? Secondly, don't you think there is some conflict between this option and the --all option? Would it make sense to rename the --all option to something like --check-clean-modified-files? - Nilay Vaish On Aug. 13, 2014, 12:51 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2331/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2014, 12:51 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10291:522c461fc667 > --------------------------- > style: Add support for a style ignore list and ignore ext/ > > There are some directories within the repository where we don't want > to enforce our coding style. Specifically, we don't want the style > hooks to warn whenever we update external code in the ext/ directory. > > > Diffs > ----- > > util/style.py 79fde1c67ed8 > > Diff: http://reviews.gem5.org/r/2331/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
