----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2362/#review5300 -----------------------------------------------------------
I'd be very keen to know if anyone has any insights/comments as to why there was any duplication of constants in the first place - Andreas Hansson On Aug. 22, 2014, 8:17 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2362/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2014, 8:17 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10316:b5b1706280c5 > --------------------------- > arch: Cleanup unused ISA traits constants > > This patch prunes unused values, and also unifies how the values are > defined (not using an enum for ALPHA), aligning the use of int vs Addr > etc. > > The patch also removes the duplication of PageBytes/PageShift and > VMPageSize/LogVMPageSize. For all ISAs the two pairs had identical > values and the latter has been removed. > > > Diffs > ----- > > src/arch/alpha/isa_traits.hh 79fde1c67ed8 > src/arch/alpha/process.cc 79fde1c67ed8 > src/arch/arm/isa_traits.hh 79fde1c67ed8 > src/arch/arm/process.cc 79fde1c67ed8 > src/arch/arm/utility.cc 79fde1c67ed8 > src/arch/mips/isa_traits.hh 79fde1c67ed8 > src/arch/mips/process.cc 79fde1c67ed8 > src/arch/null/isa_traits.hh 79fde1c67ed8 > src/arch/power/isa_traits.hh 79fde1c67ed8 > src/arch/power/process.cc 79fde1c67ed8 > src/arch/sparc/isa_traits.hh 79fde1c67ed8 > src/arch/sparc/process.cc 79fde1c67ed8 > src/arch/x86/isa_traits.hh 79fde1c67ed8 > src/arch/x86/process.cc 79fde1c67ed8 > src/kern/tru64/tru64.hh 79fde1c67ed8 > src/mem/cache/prefetch/base.cc 79fde1c67ed8 > src/mem/page_table.hh 79fde1c67ed8 > src/mem/ruby/common/Address.cc 79fde1c67ed8 > src/mem/se_translating_port_proxy.cc 79fde1c67ed8 > src/sim/process.cc 79fde1c67ed8 > src/sim/syscall_emul.hh 79fde1c67ed8 > src/sim/syscall_emul.cc 79fde1c67ed8 > src/sim/system.cc 79fde1c67ed8 > > Diff: http://reviews.gem5.org/r/2362/diff/ > > > Testing > ------- > > All regressions pass > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
