> On Aug. 24, 2014, 2:06 p.m., Andreas Hansson wrote:
> > Could you elaborate on why Time is Cycles in some cases and Ticks in 
> > others? Is this also fixing up bugs?

No, this patch is not fixing any bugs.  I changed the type of the variable
depending on how it is being used in the rest of the code.  For the files
belonging rubytest, the variable was being assigned curCycle()'s return, so I
used Cycles.  In the CacheRecorder structure, the value that is passed on to the
function addRecord() is the Tick value maintained by the replacement policy.


- Nilay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2343/#review5296
-----------------------------------------------------------


On Aug. 16, 2014, 12:35 a.m., Nilay Vaish wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/2343/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2014, 12:35 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> -------
> 
> Changeset 10285:1751a0934488
> ---------------------------
> ruby: eliminate type Time
> There is another type Time in src/base class which results in a conflict.
> 
> 
> Diffs
> -----
> 
>   src/cpu/testers/rubytest/Check.hh 79fde1c67ed8 
>   src/cpu/testers/rubytest/Check.cc 79fde1c67ed8 
>   src/cpu/testers/rubytest/RubyTester.hh 79fde1c67ed8 
>   src/cpu/testers/rubytest/RubyTester.cc 79fde1c67ed8 
>   src/mem/ruby/common/TypeDefines.hh 79fde1c67ed8 
>   src/mem/ruby/network/garnet/fixed-pipeline/NetworkInterface_d.hh 
> 79fde1c67ed8 
>   src/mem/ruby/network/garnet/fixed-pipeline/NetworkInterface_d.cc 
> 79fde1c67ed8 
>   src/mem/ruby/profiler/StoreTrace.hh 79fde1c67ed8 
>   src/mem/ruby/profiler/StoreTrace.cc 79fde1c67ed8 
>   src/mem/ruby/slicc_interface/RubySlicc_Util.hh 79fde1c67ed8 
>   src/mem/ruby/system/CacheRecorder.hh PRE-CREATION 
>   src/mem/ruby/system/CacheRecorder.cc PRE-CREATION 
> 
> Diff: http://reviews.gem5.org/r/2343/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nilay Vaish
> 
>

_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to