----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2368/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 10322:16921ef15015 --------------------------- mem: Fix a bug in the cache port flow control This patch fixes a bug in the cache port where the retry flag was reset too early, allowing new requests to arrive before the retry was actually sent, but with the event already scheduled. This caused a deadlock in the interactions with the O3 LSQ. The patche fixes the underlying issue by shifting the resetting of the flag to be done by the event that also calls sendRetry(). The patch also tidies up the flow control in recvTimingReq and ensures that we also check if we already have a retry outstanding. Diffs ----- src/mem/cache/base.hh 2a1d75864ad2 src/mem/cache/base.cc 2a1d75864ad2 src/mem/cache/cache_impl.hh 2a1d75864ad2 Diff: http://reviews.gem5.org/r/2368/diff/ Testing ------- Regressions passing Thanks, Andreas Hansson _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
