----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2400/#review5326 -----------------------------------------------------------
Thanks for finding this Andrew. Could you try to change the order of the PQ (e.g. std::priority_queue<unsigned, vector<unsigned>, std::greater<unsigned>> PQ) which will sort it the other way. I think that would be a bit clearer than the multiplication by -1. Ali - Ali Saidi On Sept. 10, 2014, 7:09 p.m., Andrew Lukefahr wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2400/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2014, 7:09 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10366:3574985d085f > --------------------------- > Fixed IQCount > > IQCount gave priority to the thread with the highest number of instructions > in the Instruction Queue, rather than the least. > > > Diffs > ----- > > src/cpu/o3/fetch_impl.hh e2c43045a81b > > Diff: http://reviews.gem5.org/r/2400/diff/ > > > Testing > ------- > > > Thanks, > > Andrew Lukefahr > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
