----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2379/#review5327 -----------------------------------------------------------
src/base/str.hh <http://reviews.gem5.org/r/2379/#comment4846> I've gotta say that it really sucks that you have to add these blurbs to these sorts of files. Whenever you do it, you then basically make it so I can't actually ever use that code in some other project. Can you really not get by without this license for stuff in base? - Nathan Binkert On Sept. 10, 2014, 7:51 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2379/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2014, 7:51 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10372:ca0d885a183a > --------------------------- > base: Clean up redundant string functions and use C++11 > > This patch does a bit of housekeeping on the string helper functions > and relies on the C++11 standard library where possible. It also does > away with our custom string hash as an implementation is already part > of the standard library. > > > Diffs > ----- > > src/base/statistics.hh e2c43045a81b > src/base/stats/text.cc e2c43045a81b > src/base/str.hh e2c43045a81b > src/base/str.cc e2c43045a81b > src/cpu/o3/lsq_unit_impl.hh e2c43045a81b > src/dev/uart8250.cc e2c43045a81b > src/sim/serialize.cc e2c43045a81b > > Diff: http://reviews.gem5.org/r/2379/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
