----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2401/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 10393:9f85c7d825cb --------------------------- alpha,arm,mips,power,x86,cpu,sim: Cleanup activate/deactivate activate(), suspend(), and halt() used on thread contexts had an optional delay parameter. However this parameter was often ignored. Also, when used, the delay was seemily arbitrarily set to 0 or 1 cycle (no other delays were ever specified). This patch removes the delay parameter and 'Events' associated with them across all ISAs and cores. Unused activate logic is also removed. Diffs ----- src/arch/alpha/utility.hh e2c43045a81b src/arch/arm/utility.hh e2c43045a81b src/arch/mips/mt.hh e2c43045a81b src/arch/mips/utility.cc e2c43045a81b src/arch/power/utility.hh e2c43045a81b src/arch/sparc/utility.hh e2c43045a81b src/arch/x86/utility.cc e2c43045a81b src/cpu/base.hh e2c43045a81b src/cpu/checker/thread_context.hh e2c43045a81b src/cpu/inorder/cpu.hh e2c43045a81b src/cpu/inorder/cpu.cc e2c43045a81b src/cpu/inorder/thread_context.hh e2c43045a81b src/cpu/inorder/thread_context.cc e2c43045a81b src/cpu/kvm/base.hh e2c43045a81b src/cpu/kvm/base.cc e2c43045a81b src/cpu/minor/cpu.hh e2c43045a81b src/cpu/minor/cpu.cc e2c43045a81b src/cpu/o3/cpu.hh e2c43045a81b src/cpu/o3/cpu.cc e2c43045a81b src/cpu/o3/fetch_impl.hh e2c43045a81b src/cpu/o3/thread_context.hh e2c43045a81b src/cpu/o3/thread_context_impl.hh e2c43045a81b src/cpu/simple/atomic.hh e2c43045a81b src/cpu/simple/atomic.cc e2c43045a81b src/cpu/simple/timing.hh e2c43045a81b src/cpu/simple/timing.cc e2c43045a81b src/cpu/simple_thread.hh e2c43045a81b src/cpu/simple_thread.cc e2c43045a81b src/cpu/thread_context.hh e2c43045a81b src/sim/process.cc e2c43045a81b Diff: http://reviews.gem5.org/r/2401/diff/ Testing ------- Thanks, Andreas Hansson _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
