changeset a16e73f1297f in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=a16e73f1297f
description:
mem: Add checks to sendTimingReq in cache
A small fix to ensure the return value is not ignored.
diffstat:
src/mem/cache/cache_impl.hh | 9 +++++++--
1 files changed, 7 insertions(+), 2 deletions(-)
diffs (26 lines):
diff -r 4466307b8a2a -r a16e73f1297f src/mem/cache/cache_impl.hh
--- a/src/mem/cache/cache_impl.hh Mon Sep 15 16:19:38 2014 -0500
+++ b/src/mem/cache/cache_impl.hh Fri Sep 19 10:35:04 2014 -0400
@@ -462,7 +462,9 @@
// Just forward the packet if caches are disabled.
if (system->bypassCaches()) {
- memSidePort->sendTimingReq(pkt);
+ // @todo This should really enqueue the packet rather
+ bool M5_VAR_USED success = memSidePort->sendTimingReq(pkt);
+ assert(success);
return true;
}
@@ -483,7 +485,10 @@
snoopPkt->busFirstWordDelay = snoopPkt->busLastWordDelay = 0;
snoopPkt->setExpressSnoop();
snoopPkt->assertMemInhibit();
- memSidePort->sendTimingReq(snoopPkt);
+ bool M5_VAR_USED success = memSidePort->sendTimingReq(snoopPkt);
+ // the packet is marked inhibited and will thus bypass any
+ // flow control
+ assert(success);
// main memory will delete snoopPkt
}
// since we're the official target but we aren't responding,
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
