changeset 28c63d075e0c in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=28c63d075e0c
description:
misc: Use safe_cast when assumptions are made about return value
This patch changes two dynamic_cast to safe_cast as we assume the
return value is not NULL (without checking).
diffstat:
src/cpu/testers/memtest/memtest.cc | 2 +-
src/mem/packet.cc | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diffs (24 lines):
diff -r b1bc989611da -r 28c63d075e0c src/cpu/testers/memtest/memtest.cc
--- a/src/cpu/testers/memtest/memtest.cc Fri Sep 19 10:35:09 2014 -0400
+++ b/src/cpu/testers/memtest/memtest.cc Fri Sep 19 10:35:11 2014 -0400
@@ -170,7 +170,7 @@
pkt->isError() ? "error" : "success");
MemTestSenderState *state =
- dynamic_cast<MemTestSenderState *>(pkt->senderState);
+ safe_cast<MemTestSenderState *>(pkt->senderState);
uint8_t *data = state->data;
uint8_t *pkt_data = pkt->getPtr<uint8_t>();
diff -r b1bc989611da -r 28c63d075e0c src/mem/packet.cc
--- a/src/mem/packet.cc Fri Sep 19 10:35:09 2014 -0400
+++ b/src/mem/packet.cc Fri Sep 19 10:35:11 2014 -0400
@@ -189,7 +189,7 @@
// check print first since it doesn't require data
if (isPrint()) {
- dynamic_cast<PrintReqState*>(senderState)->printObj(obj);
+ safe_cast<PrintReqState*>(senderState)->printObj(obj);
return false;
}
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
