> On Sept. 21, 2014, 1:17 p.m., Nathan Binkert wrote: > > Seems like you should try to get these changes approved upstream to make > > future merges easier. Also, there's no license on the code. In the past, > > Li-Shiuan has been ok with the gem5 license, so you should ask her if it is > > OK.
There is a license file in the base directory that was added in the patch before this one. It has the standard gem5/BSD license terms. Since this in an external model in the ext directory, I think that is good enough. - Brad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2407/#review5341 ----------------------------------------------------------- On Sept. 18, 2014, 9:27 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2407/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2014, 9:27 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10376:71de0404ef2e > --------------------------- > ext: dsent: adds a Python interface, drops C++ one > This patch extensively modifies DSENT so that it can be accessed using Python. > To access the Python interface, DSENT needs to compiled as a shared library. > For this purpose a CMakeLists.txt file has been added. Some of the code that > is not required is being removed. > > > Diffs > ----- > > ext/dsent/CMakeLists.txt PRE-CREATION > ext/dsent/DSENT.h PRE-CREATION > ext/dsent/DSENT.cc PRE-CREATION > ext/dsent/Makefile PRE-CREATION > ext/dsent/configs/electrical-link.cfg PRE-CREATION > ext/dsent/configs/router.cfg PRE-CREATION > ext/dsent/interface.cc PRE-CREATION > ext/dsent/libutil/Calculator.h PRE-CREATION > ext/dsent/libutil/Calculator.cc PRE-CREATION > ext/dsent/libutil/Config.h PRE-CREATION > ext/dsent/libutil/Config.cc PRE-CREATION > ext/dsent/libutil/Makefile PRE-CREATION > ext/dsent/libutil/OptionParser.h PRE-CREATION > ext/dsent/libutil/OptionParser.cc PRE-CREATION > ext/dsent/main.cc PRE-CREATION > ext/dsent/tech/TechModel.h PRE-CREATION > ext/dsent/tech/TechModel.cc PRE-CREATION > ext/dsent/util/Config.h PRE-CREATION > ext/dsent/util/Config.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/2407/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
