----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2410/#review5355 -----------------------------------------------------------
Ship it! src/sim/syscall_emul_buf.hh <http://reviews.gem5.org/r/2410/#comment4853> addr and size could even be const - Andreas Hansson On Sept. 23, 2014, 7:47 p.m., Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2410/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2014, 7:47 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10413:46f0e0fb8d5c > --------------------------- > syscall emulation: Put BufferArg classes in a separate header. > > Move the BufferArg classes that support syscall buffer args > (i.e., pointers into simulated user space) out of syscall_emul.hh > and into a new header syscall_emul_buf.hh so they are accessible > to emulated driver implementations. > > Take the opportunity to add some comments as well. > > > Diffs > ----- > > src/sim/syscall_emul.hh d96740732a61c87fe44451f5ea71b69710fe334e > src/sim/syscall_emul_buf.hh PRE-CREATION > > Diff: http://reviews.gem5.org/r/2410/diff/ > > > Testing > ------- > > > Thanks, > > Steve Reinhardt > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
