----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2423/#review5359 -----------------------------------------------------------
Ship it! src/cpu/testers/networktest/NetworkTest.py <http://reviews.gem5.org/r/2423/#comment4857> I know we've had this discussion before, but should this be Addr rather than Uint64? src/cpu/testers/networktest/networktest.cc <http://reviews.gem5.org/r/2423/#comment4858> I guess this is an intended change? Could you elaborate on the logic behind it? Also, size - 1 Some small things and request for comments - Andreas Hansson On Sept. 25, 2014, 4:53 a.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2423/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2014, 4:53 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10425:b229e72bfcc6 > --------------------------- > ruby: correct network test functionality. > One of the recent change sets altered ruby port to abort when a port already > on the retry list is again becomes a candidate for addition. The network > tester was failing because of this assert() since it issues requests for same > addresse in a rapid succession. Since the network test should issue requests > at the rate at which it is configured, the code is being changed so that the > are chosen randomly over the available address space. > > Other changes are being made to conform the network test protocol with some of > the recent changes to the ruby memory system. Some unused code in the > sequencer is being removed as well. > > > Diffs > ----- > > configs/example/ruby_network_test.py d96740732a61 > configs/ruby/Network_test.py d96740732a61 > src/cpu/testers/networktest/NetworkTest.py d96740732a61 > src/cpu/testers/networktest/networktest.cc d96740732a61 > src/mem/ruby/system/Sequencer.hh d96740732a61 > src/mem/ruby/system/Sequencer.cc d96740732a61 > src/mem/ruby/system/Sequencer.py d96740732a61 > > Diff: http://reviews.gem5.org/r/2423/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
