----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2418/#review5367 -----------------------------------------------------------
Ship it! Ship It! - Andreas Hansson On Sept. 25, 2014, 4:44 a.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2418/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2014, 4:44 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10419:7159581a94b5 > --------------------------- > ruby: remove sparse memory. > In my opinion, it creates needless complications in rest of the code. > Also, this structure hinders the move towards common set of code for > physical memory controllers. > > > Diffs > ----- > > src/mem/ruby/structures/DirectoryMemory.hh d96740732a61 > src/mem/ruby/structures/DirectoryMemory.cc d96740732a61 > src/mem/ruby/structures/SConscript d96740732a61 > src/mem/ruby/structures/SparseMemory.hh d96740732a61 > src/mem/ruby/structures/SparseMemory.cc d96740732a61 > src/mem/ruby/system/System.hh d96740732a61 > src/mem/ruby/system/System.cc d96740732a61 > > Diff: http://reviews.gem5.org/r/2418/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
