----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2442/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 10438:290510e58445 --------------------------- dev: Use shared_ptr for EthPacketData This patch transitions the EthPacketData from the ad-hoc RefCountingPtr to the c++11 shared_ptr. There are no changes in behaviour, and the code modifications are mainly replacing "new" with "make_shared". The bool casting operator for the shared_ptr is explicit, and we must therefore either cast it, compare it to NULL (p != nullptr), double negate it (!!p) or do a (p ? true : false). Diffs ----- src/base/inet.hh 28b31101d9e6 src/dev/etherlink.cc 28b31101d9e6 src/dev/etherpkt.hh 28b31101d9e6 src/dev/ethertap.cc 28b31101d9e6 src/dev/i8254xGBe.cc 28b31101d9e6 src/dev/ns_gige.cc 28b31101d9e6 src/dev/pktfifo.cc 28b31101d9e6 src/dev/sinic.cc 28b31101d9e6 Diff: http://reviews.gem5.org/r/2442/diff/ Testing ------- Thanks, Andreas Hansson _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
