----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2445/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 10441:d6a4b669100c --------------------------- mem: Use shared_ptr for Ruby Message classes This patch transitions the Ruby Message and its derived classes from the ad-hoc RefCountingPtr to the c++11 shared_ptr. There are no changes in behaviour, and the code modifications are mainly replacing "new" with "make_shared". The cloning of derived messages is slightly changed as they previously relied on overriding the base-class through covariant return types. Diffs ----- src/mem/ruby/slicc_interface/Message.hh 28b31101d9e6 src/mem/ruby/slicc_interface/NetworkMessage.hh 28b31101d9e6 src/mem/ruby/slicc_interface/RubyRequest.hh 28b31101d9e6 src/mem/ruby/system/DMASequencer.hh 28b31101d9e6 src/mem/ruby/system/DMASequencer.cc 28b31101d9e6 src/mem/ruby/system/Sequencer.cc 28b31101d9e6 src/mem/slicc/ast/EnqueueStatementAST.py 28b31101d9e6 src/mem/slicc/symbols/Type.py 28b31101d9e6 Diff: http://reviews.gem5.org/r/2445/diff/ Testing ------- Thanks, Andreas Hansson _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
