> On Sept. 30, 2014, 1:45 p.m., Andreas Hansson wrote:
> > src/mem/multi_level_page_table_impl.hh, line 181
> > <http://reviews.gem5.org/r/2461/diff/1/?file=42085#file42085line181>
> >
> > I'm not sure I'm a massive fan...but then again, I don't quite know
> > what to suggest instead.
I think reformatting into two lines would be a win:
for (; size > 0;
size -= pageSize, vaddr += pageSize, new_vaddr += pageSize) {
The other alternative would be to make a more 'normal' for loop out of it:
for (; size > 0; size -= pageSize) {
[...]
vaddr += pageSize;
new_vaddr += pageSize;
}
but while that's more conventional I don't really find it more readable;
combining the loop-related updates as it currently stands is nice in my opinion.
- Steve
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2461/#review5392
-----------------------------------------------------------
On Sept. 30, 2014, 12:32 p.m., Alexandru Dutu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/2461/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2014, 12:32 p.m.)
>
>
> Review request for Default.
>
>
> Repository: gem5
>
>
> Description
> -------
>
> Changeset 10425:6ca15e9caf70
> ---------------------------
> mem: Page Table long lines
>
> Trimmed down all the lines greater than 78 characters.
>
>
> Diffs
> -----
>
> src/mem/multi_level_page_table.hh 28b31101d9e6e5e75d04448451986d6318383f3c
> src/mem/multi_level_page_table_impl.hh
> 28b31101d9e6e5e75d04448451986d6318383f3c
> src/mem/page_table.hh 28b31101d9e6e5e75d04448451986d6318383f3c
> src/mem/page_table.cc 28b31101d9e6e5e75d04448451986d6318383f3c
>
> Diff: http://reviews.gem5.org/r/2461/diff/
>
>
> Testing
> -------
>
> Quick regression testing done.
>
>
> Thanks,
>
> Alexandru Dutu
>
>
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
