> On Sept. 30, 2014, 8:43 p.m., Andreas Hansson wrote: > > src/mem/multi_level_page_table_impl.hh, line 151 > > <http://reviews.gem5.org/r/2460/diff/1/?file=42083#file42083line151> > > > > Is fatal really suitable here? Is it a user error, or should it rather > > be a panic?
I interpret this as the user is trying to map something already mapped. I am considerring this a user fault as pages can be mapped from python scripts, however the C++ part of the simulator can call this method in which case it should be a panic. So the borderline for panic and fatal is a bit blurry for me in this case. - Alexandru ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2460/#review5391 ----------------------------------------------------------- On Sept. 30, 2014, 7:18 p.m., Alexandru Dutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2460/ > ----------------------------------------------------------- > > (Updated Sept. 30, 2014, 7:18 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10424:853fff736800 > --------------------------- > mem: Multi Level Page Table bug fix > > The multi level page table was giving false positives for already mapped > translations. This patch fixes the bogus behavior. > > > Diffs > ----- > > src/mem/multi_level_page_table_impl.hh > 28b31101d9e6e5e75d04448451986d6318383f3c > > Diff: http://reviews.gem5.org/r/2460/diff/ > > > Testing > ------- > > Quick regressions passed. > > > Thanks, > > Alexandru Dutu > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
