> On Sept. 29, 2014, 1:08 p.m., Nathan Binkert wrote: > > src/SConscript, line 66 > > <http://reviews.gem5.org/r/2425/diff/1/?file=41733#file41733line66> > > > > Why not just have one flag called skip_no_python? > > Andrew Bardsley wrote: > I left the swig related and embedded python-related flags separate as I > thought it was useful to separate out the two options (and perhaps provide a > --without-embedded-python option). I didn't end up implementing that top > level but, as I'd left the skip_no_swig distributed, felt it was useful to > keep the two flags.
I've folded the two flags into one. (Patch to follow) > On Sept. 29, 2014, 1:08 p.m., Nathan Binkert wrote: > > src/SConscript, line 652 > > <http://reviews.gem5.org/r/2425/diff/1/?file=41733#file41733line652> > > > > Shouldn't you just make it so that SwigSource automatically has the > > guard? > > Andrew Bardsley wrote: > Yes, that would be simpler. I'll make both this and the above changes. Done - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2425/#review5377 ----------------------------------------------------------- On Sept. 29, 2014, 10:37 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2425/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2014, 10:37 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10421:79fdc781826a > --------------------------- > config: Add a --without-python option to build process > > Add the ability to build libgem5 without embedded Python or the > ability to configure with Python. > > This is a prelude to a patch to allow config.ini files to be loaded > into libgem5 using only C++ which would make embedding gem5 within > other simulation systems easier. > > This adds a few registration interfaces to things which cross > between Python and C++. Namely: stats dumping and SimObject resolving > > > Diffs > ----- > > SConstruct 28b31101d9e6 > src/SConscript 28b31101d9e6 > src/base/statistics.hh 28b31101d9e6 > src/base/statistics.cc 28b31101d9e6 > src/python/SConscript 28b31101d9e6 > src/python/m5/stats/__init__.py 28b31101d9e6 > src/python/swig/pyobject.hh 28b31101d9e6 > src/python/swig/pyobject.cc 28b31101d9e6 > src/python/swig/stats.i 28b31101d9e6 > src/sim/SConscript 28b31101d9e6 > src/sim/debug.hh 28b31101d9e6 > src/sim/debug.cc 28b31101d9e6 > src/sim/init.hh 28b31101d9e6 > src/sim/init.cc 28b31101d9e6 > src/sim/init_signals.hh PRE-CREATION > src/sim/init_signals.cc PRE-CREATION > src/sim/main.cc 28b31101d9e6 > src/sim/py_interact.hh PRE-CREATION > src/sim/py_interact.cc PRE-CREATION > src/sim/serialize.hh 28b31101d9e6 > src/sim/serialize.cc 28b31101d9e6 > src/sim/stat_register.hh PRE-CREATION > src/sim/stat_register.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/2425/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
