[gem5-dev] changeset in gem5: mem: Add DRAM device size and check against c...

[Omar Naji via gem5-dev]

changeset 99d59caa4c8f in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=99d59caa4c8f
description:
        mem: Add DRAM device size and check against config

        This patch adds the size of the DRAM device to the DRAM config. It
        also compares the actual DRAM size (calculated using information from
        the config) to the size defined in the system. If these two values do
        not match gem5 will print a warning. In order to do correct DRAM
        research the size of the memory defined in the system should match the
        size of the DRAM in the config. The timing and current parameters
        found in the DRAM configs are defined for a DRAM device with a
        specific size and would differ for another device with a different
        size.

diffstat:

 src/mem/DRAMCtrl.py  |  18 ++++++++++++++++++
 src/mem/dram_ctrl.cc |  11 +++++++++++
 src/mem/dram_ctrl.hh |   1 +
 3 files changed, 30 insertions(+), 0 deletions(-)

diffs (102 lines):

diff -r 7c27480a5031 -r 99d59caa4c8f src/mem/DRAMCtrl.py
--- a/src/mem/DRAMCtrl.py       Mon Oct 20 16:48:19 2014 -0500
+++ b/src/mem/DRAMCtrl.py       Mon Oct 20 18:03:52 2014 -0400
@@ -96,6 +96,9 @@
     max_accesses_per_row = Param.Unsigned(16, "Max accesses per row before "
                                           "closing");
 
+    # size of DRAM Chip in Bytes
+    device_size = Param.MemorySize("Size of DRAM chip")
+
     # pipeline latency of the controller and PHY, split into a
     # frontend part and a backend part, with reads and writes serviced
     # by the queues only seeing the frontend contribution, and reads
@@ -305,6 +308,9 @@
 # timings based on a DDR3-1600 4 Gbit datasheet (Micron MT41J512M8) in
 # an 8x8 configuration.
 class DDR3_1600_x64(DRAMCtrl):
+    # size of device in bytes
+    device_size = '512MB'
+
     # 8x8 configuration, 8 devices each with an 8-bit interface
     device_bus_width = 8
 
@@ -397,6 +403,9 @@
 # timings based on a DDR4-2400 4 Gbit datasheet (Micron MT40A512M8)
 # in an 8x8 configuration.
 class DDR4_2400_x64(DRAMCtrl):
+    # size of device
+    device_size = '512MB'
+
     # 8x8 configuration, 8 devices each with an 8-bit interface
     device_bus_width = 8
 
@@ -488,6 +497,9 @@
     # No DLL in LPDDR2
     dll = False
 
+    # size of device
+    device_size = '512MB'
+
     # 1x32 configuration, 1 device with a 32-bit interface
     device_bus_width = 32
 
@@ -572,6 +584,9 @@
     # No DLL for WideIO
     dll = False
 
+    # size of device
+    device_size = '1024MB'
+
     # 1x128 configuration, 1 device with a 128-bit interface
     device_bus_width = 128
 
@@ -638,6 +653,9 @@
     # No DLL for LPDDR3
     dll = False
 
+    # size of device
+    device_size = '512MB'
+
     # 1x32 configuration, 1 device with a 32-bit interface
     device_bus_width = 32
 
diff -r 7c27480a5031 -r 99d59caa4c8f src/mem/dram_ctrl.cc
--- a/src/mem/dram_ctrl.cc      Mon Oct 20 16:48:19 2014 -0500
+++ b/src/mem/dram_ctrl.cc      Mon Oct 20 18:03:52 2014 -0400
@@ -62,6 +62,7 @@
     nextReqEvent(this), respondEvent(this), activateEvent(this),
     prechargeEvent(this), refreshEvent(this), powerEvent(this),
     drainManager(NULL),
+    deviceSize(p->device_size),
     deviceBusWidth(p->device_bus_width), burstLength(p->burst_length),
     deviceRowBufferSize(p->device_rowbuffer_size),
     devicesPerRank(p->devices_per_rank),
@@ -139,6 +140,16 @@
     // determine the rows per bank by looking at the total capacity
     uint64_t capacity = ULL(1) << ceilLog2(AbstractMemory::size());
 
+    // determine the dram actual capacity from the DRAM config in Mbytes
+    uint64_t deviceCapacity = deviceSize / (1024 * 1024) * devicesPerRank *
+        ranksPerChannel;
+
+    // if actual DRAM size does not match memory capacity in system warn!
+    if (deviceCapacity != capacity / (1024 * 1024))
+        warn("DRAM device capacity (%d Mbytes) does not match the "
+             "address range assigned (%d Mbytes)\n", deviceCapacity,
+             capacity / (1024 * 1024));
+
     DPRINTF(DRAM, "Memory capacity %lld (%lld) bytes\n", capacity,
             AbstractMemory::size());
 
diff -r 7c27480a5031 -r 99d59caa4c8f src/mem/dram_ctrl.hh
--- a/src/mem/dram_ctrl.hh      Mon Oct 20 16:48:19 2014 -0500
+++ b/src/mem/dram_ctrl.hh      Mon Oct 20 18:03:52 2014 -0400
@@ -463,6 +463,7 @@
      * The rowsPerBank is determined based on the capacity, number of
      * ranks and banks, the burst size, and the row buffer size.
      */
+    const uint32_t deviceSize;
     const uint32_t deviceBusWidth;
     const uint32_t burstLength;
     const uint32_t deviceRowBufferSize;
_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev