Just to clarify my point to Nilay about no functional physical memory. We need to make this configurable. There are plenty of protocols that exist, include many at AMD, that still rely on a separate copy of functional physical memory.
Thanks, Brad -----Original Message----- From: gem5-dev [mailto:[email protected]] On Behalf Of Andreas Hansson via gem5-dev Sent: Tuesday, October 21, 2014 8:07 AM To: Nilay Vaish Cc: Default Subject: Re: [gem5-dev] Review Request 2209: ruby: no functional physical memory Hi Nilay, Thanks for the feedback. I merely wanted to avoid as much rebasing as possible, and your patches feed nicely into some of the memory cleanups that are ongoing on our side. Andreas On 21/10/2014 15:23, "Nilay Vaish" <[email protected]> wrote: >This is going to take sometime. Brad and I had a chat two weeks back >and there is some work that I need to do. I am currently unsure how >soon I would it, probably another week or so. > >Am I blocking any of your patches? > >Thanks >Nilay > > >On Tue, 21 Oct 2014, Andreas Hansson wrote: > >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> http://reviews.gem5.org/r/2209/#review5418 >> ----------------------------------------------------------- >> >> >> Would be good to get this and the other Ruby/memory system >>interaction patches out there. >> >> - Andreas Hansson >> >> >> On Sept. 25, 2014, 4:41 a.m., Nilay Vaish wrote: >>> >>> ----------------------------------------------------------- >>> This is an automatically generated e-mail. To reply, visit: >>> http://reviews.gem5.org/r/2209/ >>> ----------------------------------------------------------- >>> >>> (Updated Sept. 25, 2014, 4:41 a.m.) >>> >>> >>> Review request for Default. >>> >>> >>> Repository: gem5 >>> >>> >>> Description >>> ------- >>> >>> Changeset 10417:0763ea34d0f8 >>> --------------------------- >>> ruby: no functional physical memory >>> This patch removes the functional copy of memory that was in place >>>for ruby fs simulations. All the memory accesses now source and >>>sink values to the memory maintained by ruby. >>> >>> >>> Diffs >>> ----- >>> >>> configs/example/fs.py d96740732a61 >>> configs/example/ruby_mem_test.py d96740732a61 >>> configs/example/ruby_network_test.py d96740732a61 >>> configs/example/ruby_random_test.py d96740732a61 >>> configs/ruby/MESI_Two_Level.py d96740732a61 >>> configs/ruby/MOESI_CMP_directory.py d96740732a61 >>> configs/ruby/MOESI_CMP_token.py d96740732a61 >>> configs/ruby/MOESI_hammer.py d96740732a61 >>> src/mem/protocol/MESI_Two_Level-dma.sm d96740732a61 >>> src/mem/protocol/MOESI_CMP_directory-dma.sm d96740732a61 >>> src/mem/protocol/MOESI_CMP_token-dma.sm d96740732a61 >>> src/mem/ruby/system/DMASequencer.hh d96740732a61 >>> src/mem/ruby/system/DMASequencer.cc d96740732a61 >>> src/mem/ruby/system/RubyPort.hh d96740732a61 >>> src/mem/ruby/system/RubyPort.cc d96740732a61 >>> src/mem/ruby/system/Sequencer.py d96740732a61 >>> tests/configs/pc-simple-timing-ruby.py d96740732a61 >>> >>> Diff: http://reviews.gem5.org/r/2209/diff/ >>> >>> >>> Testing >>> ------- >>> >>> >>> Thanks, >>> >>> Nilay Vaish >>> >>> >> >> > -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590 ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782 _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
