> On Oct. 31, 2014, 10:21 p.m., Nilay Vaish wrote: > > Andreas, please review this patch. I would like the ruby-related patches > > be committed soon as possible.
I'm surprised this is needed. The busBusyUntil should be initialised to a sufficiently high value that this would never occur. Could you elaborate on when the problem arises (under what conditions)? - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2469/#review5437 ----------------------------------------------------------- On Oct. 28, 2014, 3:19 a.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2469/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2014, 3:19 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10506:0d4e2892ee6a > --------------------------- > mem: dram ctrl: correct errors due to busBusyUntil variable > The busBusyUntil is unsigned and is initialised to 0, but at places > a value greater than 0 is subtracted from the variable, making its value > highly positive. This patch checks that this would not be happen before > performing the subtraction. Another possible way could be to change the > initialisation of busBusyUntil. > > > Diffs > ----- > > src/mem/dram_ctrl.cc 75d2f19fecce > > Diff: http://reviews.gem5.org/r/2469/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
