> On Nov. 18, 2014, 3:44 p.m., Nilay Vaish wrote: > > Overall I am fine with the patch. Can we set the size to 1 when the > > prefetch request > > is being created? I don't see any harm in that.
It might incur stats changes...that's my main reason for not changing anything. Perhaps it's worth fixing that as part of a patch on its own though. I would assume the prefetch should be cache line sized? - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2490/#review5469 ----------------------------------------------------------- On Nov. 17, 2014, 6:13 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2490/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2014, 6:13 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10540:0d0fabda59bd > --------------------------- > mem: Remove null-check bypassing in Packet::getPtr > > This patch removes the parameter that enables bypassing the null check > in the Packet::getPtr method. A number of call sites assume the value > to be non-null. > > The one odd case is the RubyTester, which issues zero-sized > prefetches(!), and despite being reads they had no valid data > pointer. This is now fixed, but the size oddity remains (unless anyone > object or has any good suggestions). > > Finally, in the Ruby Sequencer, appropriate checks are made for flush > packets as they have no valid data pointer. > > > Diffs > ----- > > src/cpu/testers/rubytest/Check.cc 1a9e235cab09 > src/mem/packet.hh 1a9e235cab09 > src/mem/ruby/slicc_interface/RubyRequest.cc 1a9e235cab09 > src/mem/ruby/slicc_interface/RubySlicc_Util.hh 1a9e235cab09 > src/mem/ruby/system/DMASequencer.cc 1a9e235cab09 > src/mem/ruby/system/Sequencer.cc 1a9e235cab09 > > Diff: http://reviews.gem5.org/r/2490/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
