----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2514/#review5488 -----------------------------------------------------------
The change itself makes sense, but I'd really prefer if we could avoid conditional compilation and use a kvm-agnostic interface to handle device memory. See my reply in the email thread for RB #2513. Consider this a "ship it" if it really turns out that using conditional compilation is the way to go. - Andreas Sandberg On Nov. 19, 2014, 6:44 a.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2514/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2014, 6:44 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10548:07c3cbac4cdd > --------------------------- > scons: Make the USE_KVM variable available in C++. > > We need it to determine whether we should expect KVM related parameters > exist in the cirrus graphics device. > > > Diffs > ----- > > SConstruct 288eb5ee4b0026d0cc1f02ec31748e0eaac06bc3 > > Diff: http://reviews.gem5.org/r/2514/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
