----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2510/#review5489 -----------------------------------------------------------
src/cpu/kvm/vm.hh <http://reviews.gem5.org/r/2510/#comment4940> The returned slot ID should be typedef:ed, or preferably a struct since that would make type checking more reliable. src/cpu/kvm/vm.hh <http://reviews.gem5.org/r/2510/#comment4944> Would it make sense to rename this to mapMemSlot? In my opinion, that'd be more descriptive. src/cpu/kvm/vm.hh <http://reviews.gem5.org/r/2510/#comment4942> Indentation is inconsistent with the rest of the file. src/cpu/kvm/vm.hh <http://reviews.gem5.org/r/2510/#comment4941> What's this group comment doing here and where is it terminated? src/cpu/kvm/vm.hh <http://reviews.gem5.org/r/2510/#comment4945> How about renaming this to unmapMemSlot? src/cpu/kvm/vm.cc <http://reviews.gem5.org/r/2510/#comment4943> Inconsistent indentation. Overall, I'd prefer this to be an internal API and have some way of notifying the VM through the System instead of allowing objects to poke around directly. See my reply in the email thread for RB #2513. - Andreas Sandberg On Nov. 18, 2014, 1:29 a.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2510/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2014, 1:29 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10546:b4c9aa186307 > --------------------------- > Let other objects set up memory like regions in a KVM VM. > > > Diffs > ----- > > src/cpu/kvm/vm.hh f66948658a36b6874e84ee5da37e70d351287cb4 > src/cpu/kvm/vm.cc f66948658a36b6874e84ee5da37e70d351287cb4 > > Diff: http://reviews.gem5.org/r/2510/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
