----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2498/#review5506 -----------------------------------------------------------
Ship it! src/mem/packet.hh <http://reviews.gem5.org/r/2498/#comment4954> Object of type Printable? Should this not be something else? - Nilay Vaish On Nov. 17, 2014, 6:16 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2498/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2014, 6:16 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10548:2b33b6c6b656 > --------------------------- > mem: Cleanup Packet::checkFunctional and hasData usage > > This patch cleans up the use of hasData and checkFunctional in the > packet. The latter function is also tidied up to avoid name overloading. > > > Diffs > ----- > > src/mem/cache/cache_impl.hh 1a9e235cab09 > src/mem/packet.hh 1a9e235cab09 > src/mem/packet.cc 1a9e235cab09 > > Diff: http://reviews.gem5.org/r/2498/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
