changeset 62f5f7363197 in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=62f5f7363197
description:
misc: Another round of static analysis fixups
Mostly addressing uninitialised members.
diffstat:
src/base/bigint.hh | 9 +++------
src/base/remote_gdb.cc | 5 +++--
src/dev/virtio/base.cc | 3 ++-
src/dev/virtio/base.hh | 2 +-
src/dev/virtio/fs9p.cc | 2 +-
src/dev/virtio/pci.cc | 4 ++--
src/mem/external_slave.cc | 2 +-
src/sim/insttracer.hh | 9 +++------
src/sim/process.cc | 2 ++
src/sim/syscall_emul.cc | 6 +++---
10 files changed, 21 insertions(+), 23 deletions(-)
diffs (172 lines):
diff -r 426665ec11a9 -r 62f5f7363197 src/base/bigint.hh
--- a/src/base/bigint.hh Sun Nov 23 18:01:09 2014 -0800
+++ b/src/base/bigint.hh Mon Nov 24 09:03:38 2014 -0500
@@ -39,13 +39,10 @@
struct m5_twin64_t {
uint64_t a;
uint64_t b;
- m5_twin64_t()
+ m5_twin64_t() : a(0), b(0)
{}
- m5_twin64_t(const uint64_t x)
- {
- a = x;
- b = x;
- }
+ m5_twin64_t(const uint64_t x) : a(x), b(x)
+ {}
inline m5_twin64_t& operator=(const uint64_t x)
{
a = x;
diff -r 426665ec11a9 -r 62f5f7363197 src/base/remote_gdb.cc
--- a/src/base/remote_gdb.cc Sun Nov 23 18:01:09 2014 -0800
+++ b/src/base/remote_gdb.cc Mon Nov 24 09:03:38 2014 -0500
@@ -658,12 +658,13 @@
* After the debugger is "active" (connected) it will be
* waiting for a "signaled" message from us.
*/
- if (!active)
+ if (!active) {
active = true;
- else
+ } else {
// Tell remote host that an exception has occurred.
snprintf((char *)buffer, bufferSize, "S%02x", type);
send(buffer);
+ }
// Stick frame regs into our reg cache.
getregs();
diff -r 426665ec11a9 -r 62f5f7363197 src/dev/virtio/base.cc
--- a/src/dev/virtio/base.cc Sun Nov 23 18:01:09 2014 -0800
+++ b/src/dev/virtio/base.cc Mon Nov 24 09:03:38 2014 -0500
@@ -43,7 +43,8 @@
VirtDescriptor::VirtDescriptor(PortProxy &_memProxy, VirtQueue &_queue,
Index descIndex)
- : memProxy(&_memProxy), queue(&_queue), _index(descIndex)
+ : memProxy(&_memProxy), queue(&_queue), _index(descIndex),
+ desc{0, 0, 0, 0}
{
}
diff -r 426665ec11a9 -r 62f5f7363197 src/dev/virtio/base.hh
--- a/src/dev/virtio/base.hh Sun Nov 23 18:01:09 2014 -0800
+++ b/src/dev/virtio/base.hh Mon Nov 24 09:03:38 2014 -0500
@@ -479,7 +479,7 @@
} M5_ATTR_PACKED;
VirtRing<T>(PortProxy &proxy, uint16_t size)
- : ring(size), _proxy(proxy), _base(0) {}
+ : header{0, 0}, ring(size), _proxy(proxy), _base(0) {}
/**
* Set the base address of the VirtIO ring buffer.
diff -r 426665ec11a9 -r 62f5f7363197 src/dev/virtio/fs9p.cc
--- a/src/dev/virtio/fs9p.cc Sun Nov 23 18:01:09 2014 -0800
+++ b/src/dev/virtio/fs9p.cc Mon Nov 24 09:03:38 2014 -0500
@@ -291,7 +291,7 @@
VirtIO9PDiod::VirtIO9PDiod(Params *params)
: VirtIO9PProxy(params),
- fd_to_diod(-1), fd_from_diod(-1)
+ fd_to_diod(-1), fd_from_diod(-1), diod_pid(-1)
{
}
diff -r 426665ec11a9 -r 62f5f7363197 src/dev/virtio/pci.cc
--- a/src/dev/virtio/pci.cc Sun Nov 23 18:01:09 2014 -0800
+++ b/src/dev/virtio/pci.cc Mon Nov 24 09:03:38 2014 -0500
@@ -43,8 +43,8 @@
#include "params/PciVirtIO.hh"
PciVirtIO::PciVirtIO(const Params *params)
- : PciDevice(params), vio(*params->vio),
- callbackKick(this)
+ : PciDevice(params), queueNotify(0), interruptDeliveryPending(false),
+ vio(*params->vio), callbackKick(this)
{
// Override the subsystem ID with the device ID from VirtIO
config.subsystemID = htole(vio.deviceId);
diff -r 426665ec11a9 -r 62f5f7363197 src/mem/external_slave.cc
--- a/src/mem/external_slave.cc Sun Nov 23 18:01:09 2014 -0800
+++ b/src/mem/external_slave.cc Mon Nov 24 09:03:38 2014 -0500
@@ -73,7 +73,7 @@
StubSlavePort(const std::string &name_,
ExternalSlave &owner_) :
ExternalSlave::Port(name_, owner_),
- responseEvent(*this), responsePacket(NULL)
+ responseEvent(*this), responsePacket(NULL), mustRetry(false)
{ }
Tick recvAtomic(PacketPtr packet);
diff -r 426665ec11a9 -r 62f5f7363197 src/sim/insttracer.hh
--- a/src/sim/insttracer.hh Sun Nov 23 18:01:09 2014 -0800
+++ b/src/sim/insttracer.hh Mon Nov 24 09:03:38 2014 -0500
@@ -94,13 +94,10 @@
: when(_when), thread(_thread),
staticInst(_staticInst), pc(_pc),
macroStaticInst(_macroStaticInst),
- misspeculating(spec), predicate(true)
+ misspeculating(spec), predicate(true), addr(0), addr_valid(false),
+ data_status(DataInvalid),
+ fetch_seq(0), fetch_seq_valid(false), cp_seq(0), cp_seq_valid(false)
{
- data_status = DataInvalid;
- addr_valid = false;
-
- fetch_seq_valid = false;
- cp_seq_valid = false;
}
virtual ~InstRecord() { }
diff -r 426665ec11a9 -r 62f5f7363197 src/sim/process.cc
--- a/src/sim/process.cc Sun Nov 23 18:01:09 2014 -0800
+++ b/src/sim/process.cc Mon Nov 24 09:03:38 2014 -0500
@@ -104,7 +104,9 @@
Process::Process(ProcessParams * params)
: SimObject(params), system(params->system),
+ brk_point(0), stack_base(0), stack_size(0), stack_min(0),
max_stack_size(params->max_stack_size),
+ next_thread_stack_base(0),
M5_pid(system->allocatePID()),
useArchPT(params->useArchPT),
kvmInSE(params->kvmInSE),
diff -r 426665ec11a9 -r 62f5f7363197 src/sim/syscall_emul.cc
--- a/src/sim/syscall_emul.cc Sun Nov 23 18:01:09 2014 -0800
+++ b/src/sim/syscall_emul.cc Mon Nov 24 09:03:38 2014 -0500
@@ -228,6 +228,7 @@
{
int index = 0;
int fd = p->sim_fd(p->getSyscallArg(tc, index));
+ assert(fd >= 0);
Addr bufPtr = p->getSyscallArg(tc, index);
int nbytes = p->getSyscallArg(tc, index);
BufferArg bufArg(bufPtr, nbytes);
@@ -264,6 +265,7 @@
{
int index = 0;
int fd = p->sim_fd(p->getSyscallArg(tc, index));
+ assert(fd >= 0);
uint64_t offs = p->getSyscallArg(tc, index);
int whence = p->getSyscallArg(tc, index);
@@ -278,6 +280,7 @@
{
int index = 0;
int fd = p->sim_fd(p->getSyscallArg(tc, index));
+ assert(fd >= 0);
uint64_t offset_high = p->getSyscallArg(tc, index);
uint32_t offset_low = p->getSyscallArg(tc, index);
Addr result_ptr = p->getSyscallArg(tc, index);
@@ -301,9 +304,6 @@
result_buf.copyOut(tc->getMemProxy());
return 0;
}
-
-
- return (result == (off_t)-1) ? -errno : result;
}
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
