----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2495/#review5537 -----------------------------------------------------------
src/mem/packet.hh <http://reviews.gem5.org/r/2495/#comment4965> I suggest we change the name of this and other such functions from assert* to set*. If someone were to tell me just the name of the function, I would assume the function tests the mem inhibit property for being true, like the C assert() function does. I am guessing the name has been taken from usage we come across in texts on digital logic design. - Nilay Vaish On Nov. 17, 2014, 6:14 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2495/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2014, 6:14 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10545:cf2650519e34 > --------------------------- > mem: Add checks and explanation for assertMemInhibit usage > > > Diffs > ----- > > src/mem/cache/cache_impl.hh 1a9e235cab09 > src/mem/packet.hh 1a9e235cab09 > > Diff: http://reviews.gem5.org/r/2495/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
