----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2516/#review5539 -----------------------------------------------------------
I suggest the additions being made to the Simulation.py file be made by creating new functions. I think the run function is already too big and confusing. configs/common/Options.py <http://reviews.gem5.org/r/2516/#comment4969> Can you explain why we need this separate option for restoring from a checkpoint taken using the take-simpoint-checkpoints? - Nilay Vaish On Nov. 20, 2014, 9:43 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2516/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2014, 9:43 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10548:abc6a8156083 > --------------------------- > config: Add options to take/resume from SimPoint checkpoints > > More documentation at http://gem5.org/Simpoints > > Steps to profile, generate, and use SimPoints with gem5: > > 1. To profile workload and generate SimPoint BBV file, use the > following option: > > --simpoint-profile --simpoint-interval <interval length> > > Requires single Atomic CPU and fastmem. > <interval length> is in number of instructions. > > 2. Generate SimPoint analysis using SimPoint 3.2 from UCSD. > (SimPoint 3.2 not included with this flow.) > > 3. To take gem5 checkpoints based on SimPoint analysis, use the > following option: > > --take-simpoint-checkpoint=<simpoint file path>,<weight file > path>,<interval length>,<warmup length> > > <simpoint file> and <weight file> is generated by SimPoint analysis > tool from UCSD. SimPoint 3.2 format expected. <interval length> and > <warmup length> are in number of instructions. > > 4. To resume from gem5 SimPoint checkpoints, use the following option: > > --restore-simpoint-checkpoint -r <N> --checkpoint-dir <simpoint > checkpoint path> > > <N> is (SimPoint index + 1). E.g., "-r 1" will resume from SimPoint > #0. > > > Diffs > ----- > > configs/common/Options.py b61dc895269a > configs/common/Simulation.py b61dc895269a > configs/example/fs.py b61dc895269a > > Diff: http://reviews.gem5.org/r/2516/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
