----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2520/#review5554 -----------------------------------------------------------
src/dev/x86/i8042.cc <http://reviews.gem5.org/r/2520/#comment4981> for (auto& k : keys) bufferData(&k, 1) I would suggest "x86, dev" as the keyword(s) - Andreas Hansson On Nov. 22, 2014, 1:32 p.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2520/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2014, 1:32 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10556:76e90695e93b > --------------------------- > x86: i8042: Add VNC keyboard input support. > > This fixes up and fleshes out the keyboard model within the i8042 so that it > can return keyboard input realistically enough to satisfy the kernel. > > One notable change was to turn off the convertScanCodes bit. That bit > basically enables a compatibility mode which makes the keyboard return > scancodes from set 1 which the XT computer used. We want to turn off that > translation so that we get scancode set 2, the standard set which was used by > the AT computer. That's also what the existing X11 keycode => scancode > function developed for ARM returns. > > > Diffs > ----- > > src/dev/x86/i8042.hh 6317351a288c0349c5855c7431bc1eeade61605c > src/dev/x86/i8042.cc 6317351a288c0349c5855c7431bc1eeade61605c > > Diff: http://reviews.gem5.org/r/2520/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
