----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2538/#review5604 -----------------------------------------------------------
Ship it! Seems fine other than the one comment I have made below. src/base/remote_gdb.hh <http://reviews.gem5.org/r/2538/#comment5014> Should this not be divCeil() * sizeof(uint64_t)? - Nilay Vaish On Nov. 25, 2014, 11:47 a.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2538/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2014, 11:47 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10566:b350c8558d2f > --------------------------- > misc: Make the GDB register cache accessible in various sized chunks. > > Not all ISAs have 64 bit sized registers, so it's not always very convenient > to access the GDB register cache in 64 bit sized chunks. This change makes it > accessible in 8, 16, 32, or 64 bit chunks. The MIPS and ARM implementations > were working around that limitation by bundling and unbundling 32 bit values > into 64 bit values. That code has been removed. > > > Diffs > ----- > > src/arch/alpha/remote_gdb.cc f9fb64a72259a2514080151b5250a04c575d443a > src/arch/arm/remote_gdb.hh f9fb64a72259a2514080151b5250a04c575d443a > src/arch/arm/remote_gdb.cc f9fb64a72259a2514080151b5250a04c575d443a > src/arch/mips/remote_gdb.hh f9fb64a72259a2514080151b5250a04c575d443a > src/arch/mips/remote_gdb.cc f9fb64a72259a2514080151b5250a04c575d443a > src/arch/sparc/remote_gdb.cc f9fb64a72259a2514080151b5250a04c575d443a > src/base/remote_gdb.hh f9fb64a72259a2514080151b5250a04c575d443a > > Diff: http://reviews.gem5.org/r/2538/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
