----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2541/#review5605 -----------------------------------------------------------
Ship it! Ship It! - Nilay Vaish On Nov. 25, 2014, 11:47 a.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2541/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2014, 11:47 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10569:87cda70be35d > --------------------------- > sim: Make it possible to override the breakpoint length check. > > The check which makes sure the length of the breakpoint being written is the > same as a MachInst is only correct on fixed instruction width ISAs. Instead of > incorrectly applying that check to all ISAs, this change makes that the > default check and lets ISA specific GDB classes override it. > > > Diffs > ----- > > src/base/remote_gdb.hh f9fb64a72259a2514080151b5250a04c575d443a > src/base/remote_gdb.cc f9fb64a72259a2514080151b5250a04c575d443a > > Diff: http://reviews.gem5.org/r/2541/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
