> On Nov. 30, 2014, 6:38 p.m., Nilay Vaish wrote: > > I do not see much value though, but I am fine with patch. > > Gabe Black wrote: > The ChromeOS kernel needs lots of command line arguments, both to > configure the kernel and to leave information for the system at large. This > is so we don't have to have a custom hack on top of the config scripts to jam > those in there. > > I would really, really like to see the config stuff modularized way more > than it is now, so that it's realistic to create a different config script > which reuses the checked in code instead of having to modify it in place.
Should this go in then? - Gabe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2524/#review5591 ----------------------------------------------------------- On Nov. 23, 2014, 7:26 a.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2524/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2014, 7:26 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10561:b2a85a0c0571 > --------------------------- > config: Add two options for setting the kernel command line. > > Both options accept template which will, through python string formatting, > have "mem", "disk", and "script" values substituted in from the mdesc. > Additional values can be used on a case by case basis by passing them as > keyword arguments to the fillInCmdLine function. That makes it possible to > have specialized parameters for a particular ISA, for instance. > > The first option lets you specify the template directly, and the other lets > you specify a file which has the template in it. > > > Diffs > ----- > > configs/common/FSConfig.py 6317351a288c0349c5855c7431bc1eeade61605c > configs/common/Options.py 6317351a288c0349c5855c7431bc1eeade61605c > configs/example/fs.py 6317351a288c0349c5855c7431bc1eeade61605c > > Diff: http://reviews.gem5.org/r/2524/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
