> On Dec. 2, 2014, 6:26 a.m., Steve Reinhardt wrote: > > It would be nice to actually test this code just to be sure nothing slipped > > through, but style-wise it does look like an improvement.
I might spend some personal time (vs. work time) at some point seeing if I can figure out what the problem is. This leads to what I'd like to eventually do to unify FS and SE more which I sent an email about. - Gabe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2547/#review5602 ----------------------------------------------------------- On Dec. 1, 2014, 10:28 a.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2547/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2014, 10:28 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > changesets: > 10561:965db4ba332b "x86: Clean up style in process.cc." > > > Diffs > ----- > > src/arch/x86/process.cc dd04eb06ad42 > > Diff: http://reviews.gem5.org/r/2547/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
