----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2556/#review5650 -----------------------------------------------------------
Ship it! Agreed, I'm a big fan of patches that are a net reduction in LOC, especially if there's no loss in functionality. I wouldn't be surprised if this is actually more robust too. - Steve Reinhardt On Dec. 5, 2014, 3:15 a.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2556/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2014, 3:15 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10601:db4414e1e9a9 > --------------------------- > misc: Generalize GDB single stepping. > > The new single stepping implementation for x86 doesn't rely on any ISA > specific properties or functionality. This change pulls out the per ISA > implementation of those functions and promotes the X86 implementation to the > base class. > > One drawback of that implementation is that the CPU might stop on an > instruction twice if it's affected by both breakpoints and single stepping. > While that might be a little surprising, it's harmless and would only happen > under somewhat unlikely circumstances. > > > Diffs > ----- > > src/arch/alpha/remote_gdb.hh bd68c6838b9fda0990816493e8ee591b07a10e5e > src/arch/alpha/remote_gdb.cc bd68c6838b9fda0990816493e8ee591b07a10e5e > src/arch/arm/remote_gdb.hh bd68c6838b9fda0990816493e8ee591b07a10e5e > src/arch/arm/remote_gdb.cc bd68c6838b9fda0990816493e8ee591b07a10e5e > src/arch/mips/remote_gdb.hh bd68c6838b9fda0990816493e8ee591b07a10e5e > src/arch/mips/remote_gdb.cc bd68c6838b9fda0990816493e8ee591b07a10e5e > src/arch/power/remote_gdb.hh bd68c6838b9fda0990816493e8ee591b07a10e5e > src/arch/sparc/remote_gdb.hh bd68c6838b9fda0990816493e8ee591b07a10e5e > src/arch/sparc/remote_gdb.cc bd68c6838b9fda0990816493e8ee591b07a10e5e > src/arch/x86/remote_gdb.hh bd68c6838b9fda0990816493e8ee591b07a10e5e > src/arch/x86/remote_gdb.cc bd68c6838b9fda0990816493e8ee591b07a10e5e > src/base/remote_gdb.hh bd68c6838b9fda0990816493e8ee591b07a10e5e > src/base/remote_gdb.cc bd68c6838b9fda0990816493e8ee591b07a10e5e > > Diff: http://reviews.gem5.org/r/2556/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
