[gem5-dev] changeset in gem5: misc: Rename the GDB "Event" event class to I...

[Gabe Black via gem5-dev]

changeset 3d7653a2538b in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=3d7653a2538b
description:
        misc: Rename the GDB "Event" event class to InputEvent.

        The "Event" name is the same as the base event class. That's a bit 
confusing,
        and makes it a little awkward to add other event types.

diffstat:

 src/base/remote_gdb.cc |  30 +++++++++++++++---------------
 src/base/remote_gdb.hh |  18 +++++++++---------
 2 files changed, 24 insertions(+), 24 deletions(-)

diffs (160 lines):

diff -r bd68c6838b9f -r 3d7653a2538b src/base/remote_gdb.cc
--- a/src/base/remote_gdb.cc    Fri Dec 05 01:51:49 2014 -0800
+++ b/src/base/remote_gdb.cc    Fri Dec 05 22:34:42 2014 -0800
@@ -166,18 +166,18 @@
 //
 //
 
-GDBListener::Event::Event(GDBListener *l, int fd, int e)
+GDBListener::InputEvent::InputEvent(GDBListener *l, int fd, int e)
     : PollEvent(fd, e), listener(l)
 {}
 
 void
-GDBListener::Event::process(int revent)
+GDBListener::InputEvent::process(int revent)
 {
     listener->accept();
 }
 
 GDBListener::GDBListener(BaseRemoteGDB *g, int p)
-    : event(NULL), gdb(g), port(p)
+    : inputEvent(NULL), gdb(g), port(p)
 {
     assert(!gdb->listener);
     gdb->listener = this;
@@ -185,8 +185,8 @@
 
 GDBListener::~GDBListener()
 {
-    if (event)
-        delete event;
+    if (inputEvent)
+        delete inputEvent;
 }
 
 string
@@ -208,8 +208,8 @@
         port++;
     }
 
-    event = new Event(this, listener.getfd(), POLLIN);
-    pollQueue.schedule(event);
+    inputEvent = new InputEvent(this, listener.getfd(), POLLIN);
+    pollQueue.schedule(inputEvent);
 
 #ifndef NDEBUG
     gdb->number = debuggers.size();
@@ -241,12 +241,12 @@
     }
 }
 
-BaseRemoteGDB::Event::Event(BaseRemoteGDB *g, int fd, int e)
+BaseRemoteGDB::InputEvent::InputEvent(BaseRemoteGDB *g, int fd, int e)
     : PollEvent(fd, e), gdb(g)
 {}
 
 void
-BaseRemoteGDB::Event::process(int revent)
+BaseRemoteGDB::InputEvent::process(int revent)
 {
     BaseCPU *cpu = gdb->context->getCpuPtr();
     EventQueue *eq = cpu->comInstEventQueue[gdb->context->threadId()];
@@ -269,7 +269,7 @@
 }
 
 BaseRemoteGDB::BaseRemoteGDB(System *_system, ThreadContext *c, size_t 
cacheSize)
-    : event(NULL), trapEvent(this), listener(NULL), number(-1), fd(-1),
+    : inputEvent(NULL), trapEvent(this), listener(NULL), number(-1), fd(-1),
       active(false), attached(false),
       system(_system), context(c),
       gdbregs(cacheSize)
@@ -279,8 +279,8 @@
 
 BaseRemoteGDB::~BaseRemoteGDB()
 {
-    if (event)
-        delete event;
+    if (inputEvent)
+        delete inputEvent;
 }
 
 string
@@ -298,8 +298,8 @@
 {
     fd = f;
 
-    event = new Event(this, fd, POLLIN);
-    pollQueue.schedule(event);
+    inputEvent = new InputEvent(this, fd, POLLIN);
+    pollQueue.schedule(inputEvent);
 
     attached = true;
     DPRINTFN("remote gdb attached\n");
@@ -312,7 +312,7 @@
     close(fd);
     fd = -1;
 
-    pollQueue.remove(event);
+    pollQueue.remove(inputEvent);
     DPRINTFN("remote gdb detached\n");
 }
 
diff -r bd68c6838b9f -r 3d7653a2538b src/base/remote_gdb.hh
--- a/src/base/remote_gdb.hh    Fri Dec 05 01:51:49 2014 -0800
+++ b/src/base/remote_gdb.hh    Fri Dec 05 22:34:42 2014 -0800
@@ -105,17 +105,17 @@
     virtual const char * gdb_command(char cmd);
 
   protected:
-    class Event : public PollEvent
+    class InputEvent : public PollEvent
     {
       protected:
         BaseRemoteGDB *gdb;
 
       public:
-        Event(BaseRemoteGDB *g, int fd, int e);
+        InputEvent(BaseRemoteGDB *g, int fd, int e);
         void process(int revent);
     };
 
-    class TrapEvent : public ::Event
+    class TrapEvent : public Event
     {
       protected:
         int _type;
@@ -129,8 +129,8 @@
         void process();
     };
 
-    friend class Event;
-    Event *event;
+    friend class InputEvent;
+    InputEvent *inputEvent;
     TrapEvent trapEvent;
     GDBListener *listener;
     int number;
@@ -270,18 +270,18 @@
 class GDBListener
 {
   protected:
-    class Event : public PollEvent
+    class InputEvent : public PollEvent
     {
       protected:
         GDBListener *listener;
 
       public:
-        Event(GDBListener *l, int fd, int e);
+        InputEvent(GDBListener *l, int fd, int e);
         void process(int revent);
     };
 
-    friend class Event;
-    Event *event;
+    friend class InputEvent;
+    InputEvent *inputEvent;
 
   protected:
     ListenSocket listener;
_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev