----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2561/#review5666 -----------------------------------------------------------
src/sim/insttracer.hh <http://reviews.gem5.org/r/2561/#comment5053> Yeah, that was always a pain. It made some things a lot harder to debug. src/sim/insttracer.hh <http://reviews.gem5.org/r/2561/#comment5054> Capitalization, execution => executing. The wording still makes it a little vague what the polarity of this flag means, but I think I got it. It would be nice if it could be clarified. Should a block style comment like this have anything on its first line? IE /* foo */ vs. /* * foo */ src/sim/insttracer.hh <http://reviews.gem5.org/r/2561/#comment5055> void on its own line. I don't think there's much to gain from squishing everything on one line like that. But it's not the end of the world. - Gabe Black On Dec. 10, 2014, 5:55 p.m., Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2561/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2014, 5:55 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10610:67236857bfc6 > --------------------------- > sim: Clean up InstRecord > > Track memory size and flags as well as add some comments and consts. > > > Diffs > ----- > > src/cpu/base_dyn_inst.hh 4e09ae443c96 > src/cpu/exetrace.cc 4e09ae443c96 > src/cpu/inorder/resources/cache_unit.cc 4e09ae443c96 > src/cpu/minor/lsq.cc 4e09ae443c96 > src/cpu/simple/atomic.cc 4e09ae443c96 > src/cpu/simple/timing.cc 4e09ae443c96 > src/sim/insttracer.hh 4e09ae443c96 > > Diff: http://reviews.gem5.org/r/2561/diff/ > > > Testing > ------- > > > Thanks, > > Ali Saidi > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
