----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2563/#review5685 -----------------------------------------------------------
I didn't see anything that seemed wrong, but I don't know anything about protobufs. src/cpu/SConscript <http://reviews.gem5.org/r/2563/#comment5059> From context I know what this is trying to say, but the sentence doesn't really make sense. - Gabe Black On Dec. 10, 2014, 5:57 p.m., Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2563/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2014, 5:57 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10612:3e9fa4687536 > --------------------------- > cpu: add support for outputing a protobuf formatted CPU trace > > > Diffs > ----- > > src/cpu/InstPBTrace.py PRE-CREATION > src/cpu/SConscript 4e09ae443c96 > src/cpu/inst_pb_trace.hh PRE-CREATION > src/cpu/inst_pb_trace.cc PRE-CREATION > src/proto/SConscript 4e09ae443c96 > src/proto/inst.proto PRE-CREATION > util/decode_inst_trace.py PRE-CREATION > > Diff: http://reviews.gem5.org/r/2563/diff/ > > > Testing > ------- > > > Thanks, > > Ali Saidi > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
