----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2584/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 10608:49338f652153 --------------------------- base: Fix assigning between identical bitfields. If two bitfields are of the same type, also implying that they have the same first and last bit positions, the existing implementation would copy the entire bitfield. That includes the __data member which is shared among all the bitfields, effectively overwritting the entire bitunion. This change also adjusts the write only signed bitfield assignment operator to be like the unsigned version, using "using" instead of implementing it again and calling down to the underlying implementation. Diffs ----- src/base/bitunion.hh a0cb57e1c072965dcdd51465beff37b264b41424 Diff: http://reviews.gem5.org/r/2584/diff/ Testing ------- Thanks, Gabe Black _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
