----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2593/#review5710 -----------------------------------------------------------
Ship it! Ship It! - Gabe Black On Dec. 23, 2014, 2:51 p.m., Joel Hestness wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2593/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2014, 2:51 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10629:0de378f6af0e > --------------------------- > syscall emulation: Return correct writev value > > According to Linux man pages, if writev is successful, it returns the total > number of bytes written. Otherwise, it returns an error code. Instead of > returning 0, return the result from the actual call to writev in the system > call. > > > Diffs > ----- > > src/sim/syscall_emul.hh c9b7e0c69f88673c79c4a033d4425cc1bba00a6d > > Diff: http://reviews.gem5.org/r/2593/diff/ > > > Testing > ------- > > Fixes infinite loop output printing in Delauney Mesh Refinement benchmark > (LonestarGPU), which uses ofstream to buffer output to file. > > > Thanks, > > Joel Hestness > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
