----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2594/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 10642:21eede796ebc --------------------------- mem: Clean up Request initialisation This patch tidies up how we create and set the fields of a Request. In essence it tries to use the constructor where possible (as opposed to setPhys and setVirt), thus avoiding spreading the information across a number of locations. In fact, setPhys is made private as part of this patch, and a number of places where we callede setVirt instead uses the appropriate constructor. Diffs ----- src/arch/arm/isa.cc 9ac724889705 src/cpu/checker/cpu.cc 9ac724889705 src/cpu/kvm/base.hh 9ac724889705 src/cpu/kvm/base.cc 9ac724889705 src/cpu/kvm/x86_cpu.hh 9ac724889705 src/cpu/kvm/x86_cpu.cc 9ac724889705 src/cpu/simple/timing.hh 9ac724889705 src/cpu/simple/timing.cc 9ac724889705 src/cpu/testers/memtest/memtest.cc 9ac724889705 src/cpu/testers/networktest/networktest.cc 9ac724889705 src/mem/port_proxy.cc 9ac724889705 src/mem/request.hh 9ac724889705 src/mem/ruby/system/CacheRecorder.cc 9ac724889705 Diff: http://reviews.gem5.org/r/2594/diff/ Testing ------- Thanks, Andreas Hansson _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
