> On Dec. 17, 2014, 9:34 a.m., Ali Saidi wrote: > > Will this run into problems if we build the unit test with the fast compile > > options? Since the asserts are compiled out dose end up not writing?
Perhaps split into two lines. Also, should it be assert or EXPECT_TRUE or similar? - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2583/#review5689 ----------------------------------------------------------- On Dec. 17, 2014, 7:06 a.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2583/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2014, 7:06 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10607:f07dbaea0ba3 > --------------------------- > tests: Fix building the circletest unittest. > > The compiler was upset because the return value from the "write" funciton > wasn't being used. > > > Diffs > ----- > > src/unittest/circletest.cc a0cb57e1c072965dcdd51465beff37b264b41424 > > Diff: http://reviews.gem5.org/r/2583/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
