----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2552/#review5731 -----------------------------------------------------------
src/python/m5/simulate.py <http://reviews.gem5.org/r/2552/#comment5100> I would suggest to make it fatal assuming all regressions pass Could we perhaps change the keyword to "sim"? Also, is the summary line <65 char? The description also looks like it needs to be wrapped at 80 char. - Andreas Hansson On Dec. 4, 2014, 6:45 p.m., Cagdas Dirik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2552/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2014, 6:45 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > This change adds an event queue empty check after instantiation. SimObjects > that do self-initiated processing are expected to schedule internal events > when startup() is called. There are modules which do not follow this > guideline. And this creates issues with systemc version - especially when > restoring from checkpoint. This change simply prints a warning message which > is intended as a help in debugging failures. > > > Diffs > ----- > > src/python/m5/simulate.py fea29fc045ee > > Diff: http://reviews.gem5.org/r/2552/diff/ > > > Testing > ------- > > > Thanks, > > Cagdas Dirik > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
