----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2590/#review5739 -----------------------------------------------------------
Can you be more specific about what doesn't work? Do we really need to back out all of the enabled features? Also, it would be nice to replace the comments with different comments, rather than just getting rid of them. If you want to keep this as a pure backout of the previous commit and make the other changes separately, that would be fine. - Steve Reinhardt On Dec. 22, 2014, 4:37 p.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2590/ > ----------------------------------------------------------- > > (Updated Dec. 22, 2014, 4:37 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10607:334a1f4026ca > --------------------------- > cpuid, x86: Revert "Enabling more features in CPUid" > > That change enables CPUID bits for features that aren't implemented in gem5. > If a simulated system tries to use those features because it was told it > could, bad things can happen. > > > Diffs > ----- > > src/arch/x86/cpuid.cc a0cb57e1c072965dcdd51465beff37b264b41424 > > Diff: http://reviews.gem5.org/r/2590/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
