----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2602/#review5756 -----------------------------------------------------------
Ship it! Looks ok to me. - Marc Orr On Jan. 12, 2015, 4:10 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2602/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2015, 4:10 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10657:9fe25a9a8c8a > --------------------------- > mem: Remove unused Packet src and dest fields > > This patch takes the final step in removing the src and dest fields in > the packet. These fields were rather confusing in that they only > remember a single multiplexing component, and pushed the > responsibility to the bridge and caches to store the fields in a > senderstate, thus effectively creating a stack. With the recent > changes to the crossbar response routing the crossbar is now > responsible without relying on the packet fields. Thus, these > variables are now unused and can be removed. > > > Diffs > ----- > > src/arch/x86/pagetable_walker.cc cd95d4d51659 > src/mem/packet.hh cd95d4d51659 > > Diff: http://reviews.gem5.org/r/2602/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
