> On Jan. 14, 2015, 8:52 p.m., Gabe Black wrote: > > This will break GDB single stepping.
If I undestand correctly, it won't be affected. When set, the GDB single step schedules the corresponding event at the comInstEventQueue. The comInstEventQueue services events using the Counter numInst which is incremented in BaseCPU class in the count function. The count function in its turn is called on every commit even if it's not the last microop but it checks if it is the last microop before it increments numInst. If I am wrong and it does affect the single stepping, then I can change the patch. It would make more sense if the ppCommit probe notifies the listener with the macroop when the last microop is committed or the instruciton when it not macro coded. - Nikos ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2604/#review5755 ----------------------------------------------------------- On Jan. 14, 2015, 6:13 p.m., Nikos Nikoleris wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2604/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2015, 6:13 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10646:f72bd92d39d2 > --------------------------- > cpu: commit probe notification on every microop or macroop > > The ppCommit should notify the attached listener every time the cpu commits > a microop or non microcoded insturction. The listener can then decide > whether it will process only the last microop (eg. SimPoint probe). > > > Diffs > ----- > > src/cpu/simple/atomic.cc cd95d4d51659 > src/cpu/simple/probes/simpoint.cc cd95d4d51659 > > Diff: http://reviews.gem5.org/r/2604/diff/ > > > Testing > ------- > > > Thanks, > > Nikos Nikoleris > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
