----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2603/#review5760 -----------------------------------------------------------
Ship it! I'd suggest "config, arm:" Thanks for fixing this. - Andreas Hansson On Jan. 15, 2015, 5:23 a.m., Malek Musleh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2603/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2015, 5:23 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10646:2bfc90888091 > --------------------------- > config: arm: fix os_flags > > Fix the makeArmSystem routine to reflect recent changes that support kernel > commandline option when running android. Without this fix, trying to run > android encounters a 'reference before assignment' error. > > > Diffs > ----- > > configs/common/FSConfig.py cd95d4d51659 > > Diff: http://reviews.gem5.org/r/2603/diff/ > > > Testing > ------- > > > Thanks, > > Malek Musleh > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
