----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2597/#review5761 -----------------------------------------------------------
src/mem/ruby/system/RubyPort.cc <http://reviews.gem5.org/r/2597/#comment5103> Why move this print statement? This change might cause merge conflicts when people pull updates. - Marc Orr On Jan. 5, 2015, 4:50 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2597/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2015, 4:50 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10645:feaa007b5faf > --------------------------- > mem: Always use SenderState for response routing in RubyPort > > This patch aligns how the response routing is done in the RubyPort, > using the SenderState for both memory and I/O accesses. Before this > patch, only the I/O used the SenderState, whereas the memory accesses > relied on the src field in the packet. With this patch we shift to > using SenderState in both cases, thus not relying on the src field any > longer. > > > Diffs > ----- > > src/mem/ruby/system/RubyPort.cc 9ac724889705 > src/mem/ruby/system/Sequencer.cc 9ac724889705 > > Diff: http://reviews.gem5.org/r/2597/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
