----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2607/#review5779 -----------------------------------------------------------
It looks sensible, but I wonder if we could not somehow move all this to the BaseCPU? Also, what do these states mean for an SMT? Is there a need for threadIdle and coreIdle? - Andreas Hansson On Jan. 21, 2015, midnight, Alexandru Dutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2607/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, midnight) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10652:1dd33bc912af > --------------------------- > O3CPU: Idle CPU status logic revised > This patch sets the CPU status to idle when the last active thread gets > suspended. > > > Diffs > ----- > > src/cpu/o3/cpu.cc a6fe75e8296b0dd2293596d11b2ac0f842b10463 > > Diff: http://reviews.gem5.org/r/2607/diff/ > > > Testing > ------- > > Tested ALPHA and X86 quick SE regressions. Also, tested ALPHA multi-program > SMT with small applications. > > > Thanks, > > Alexandru Dutu > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
